/[svn]/libgig/trunk/src/gig.cpp

Diff of /libgig/trunk/src/gig.cpp

Parent Directory | Revision Log | View Patch Patch

-revision 2985 by schoenebeck,
Tue Sep 20 22:13:37 2016 UTC
+revision 3115 by schoenebeck,
Sat Apr 15 20:17:05 2017 UTC
 Line 269 
 namespace {
       * steps.
       *
       * Once the whole data was processed by __calculateCRC(), one should
-      * call __encodeCRC() to get the final CRC result.
+      * call __finalizeCRC() to get the final CRC result.
       *
       * @param buf     - pointer to data the CRC shall be calculated of
       * @param bufSize - size of the data to be processed
       * @param crc     - variable the CRC sum shall be stored to
       */
-     static void __calculateCRC(unsigned char* buf, int bufSize, uint32_t& crc) {
+     static void __calculateCRC(unsigned char* buf, size_t bufSize, uint32_t& crc) {
-         for (int i = 0 ; i < bufSize ; i++) {
+         for (size_t i = 0 ; i < bufSize ; i++) {
              crc = __CRCTable[(crc ^ buf[i]) & 0xff] ^ (crc >> 8);
          }
      }
 Line 286 
 namespace {
       *
       * @param crc - variable previously passed to __calculateCRC()
       */
-     inline static uint32_t __encodeCRC(const uint32_t& crc) {
+     inline static void __finalizeCRC(uint32_t& crc) {
-         return crc ^ 0xffffffff;
+         crc ^= 0xffffffff;
      }
 Line 338 
 namespace {
       *                         ('wvpl') list chunk
       * @param fileNo         - number of an extension file where this sample
       *                         is located, 0 otherwise
+      * @param index          - wave pool index of sample (may be -1 on new sample)
       */
-     Sample::Sample(File* pFile, RIFF::List* waveList, file_offset_t WavePoolOffset, unsigned long fileNo) : DLS::Sample((DLS::File*) pFile, waveList, WavePoolOffset) {
+     Sample::Sample(File* pFile, RIFF::List* waveList, file_offset_t WavePoolOffset, unsigned long fileNo, int index)
+         : DLS::Sample((DLS::File*) pFile, waveList, WavePoolOffset)
+     {
          static const DLS::Info::string_length_t fixedStringLengths[] = {
              { CHUNK_ID_INAM, 64 },
              { 0, 0 }
-Line 349 
 namespace {
+Line 352 
 namespace {
          FileNo = fileNo;
          __resetCRC(crc);
+         // if this is not a new sample, try to get the sample's already existing
+         // CRC32 checksum from disk, this checksum will reflect the sample's CRC32
+         // checksum of the time when the sample was consciously modified by the
+         // user for the last time (by calling Sample::Write() that is).
+         if (index >= 0) { // not a new file ...
+             try {
+                 uint32_t crc = pFile->GetSampleChecksumByIndex(index);
+                 this->crc = crc;
+             } catch (...) {}
+         }
          pCk3gix = waveList->GetSubChunk(CHUNK_ID_3GIX);
          if (pCk3gix) {
-Line 1281 
 namespace {
+Line 1294 
 namespace {
          // if this is the last write, update the checksum chunk in the
          // file
          if (pCkData->GetPos() == pCkData->GetSize()) {
+             __finalizeCRC(crc);
              File* pFile = static_cast<File*>(GetParent());
-             pFile->SetSampleChecksum(this, __encodeCRC(crc));
+             pFile->SetSampleChecksum(this, crc);
          }
          return res;
      }
-Line 1342 
 namespace {
+Line 1356 
 namespace {
      }
      /**
+      * Returns the CRC-32 checksum of the sample's raw wave form data at the
+      * time when this sample's wave form data was modified for the last time
+      * by calling Write(). This checksum only covers the raw wave form data,
+      * not any meta informations like i.e. bit depth or loop points. Since
+      * this method just returns the checksum stored for this sample i.e. when
+      * the gig file was loaded, this method returns immediately. So it does no
+      * recalcuation of the checksum with the currently available sample wave
+      * form data.
+      *
+      * @see VerifyWaveData()
+      */
+     uint32_t Sample::GetWaveDataCRC32Checksum() {
+         return crc;
+     }
+     /**
       * Checks the integrity of this sample's raw audio wave data. Whenever a
       * Sample's raw wave data is intentionally modified (i.e. by calling
       * Write() and supplying the new raw audio wave form data) a CRC32 checksum
-Line 1357 
 namespace {
+Line 1387 
 namespace {
       * default whenever a gig file is loaded. So this method must be called
       * explicitly to fulfill this task.
       *
+      * @param pActually - (optional) if provided, will be set to the actually
+      *                    calculated checksum of the current raw wave form data,
+      *                    you can get the expected checksum instead by calling
+      *                    GetWaveDataCRC32Checksum()
       * @returns true if sample is OK or false if the sample is damaged
       * @throws Exception if no checksum had been stored to disk for this
       *         sample yet, or on I/O issues
+      * @see GetWaveDataCRC32Checksum()
       */
-     bool Sample::VerifyWaveData() {
+     bool Sample::VerifyWaveData(uint32_t* pActually) {
-         File* pFile = static_cast<File*>(GetParent());
+         //File* pFile = static_cast<File*>(GetParent());
-         const uint32_t referenceCRC = pFile->GetSampleChecksum(this);
          uint32_t crc = CalculateWaveDataChecksum();
-         return crc == referenceCRC;
+         if (pActually) *pActually = crc;
+         return crc == this->crc;
      }
      uint32_t Sample::CalculateWaveDataChecksum() {
-Line 1382 
 namespace {
+Line 1417 
 namespace {
              if (nRead <= 0) break;
              __calculateCRC(&buffer[0], nRead * FrameSize, crc);
          }
-         __encodeCRC(crc);
+         __finalizeCRC(crc);
          return crc;
      }
-Line 1596 
 namespace {
+Line 1631 
 namespace {
              EG2Attack                       = 0.0;
              EG2Decay1                       = 0.005;
              EG2Sustain                      = 1000;
-             EG2Release                      = 0.3;
+             EG2Release                      = 60;
              LFO2ControlDepth                = 0;
              LFO2Frequency                   = 1.0;
              LFO2InternalDepth               = 0;
-Line 1795 
 namespace {
+Line 1830 
 namespace {
          // update '3ewa' chunk with DimensionRegion's current settings
-         const uint32_t chunksize = _3ewa->GetNewSize();
+         const uint32_t chunksize = (uint32_t) _3ewa->GetNewSize();
          store32(&pData[0], chunksize); // unknown, always chunk size?
          const int32_t lfo3freq = (int32_t) GIG_EXP_ENCODE(LFO3Frequency);
-Line 3763 
 namespace {
+Line 3798 
 namespace {
      DimensionRegion* Region::GetDimensionRegionByValue(const uint DimValues[8]) {
          uint8_t bits;
          int veldim = -1;
-         int velbitpos;
+         int velbitpos = 0;
          int bitpos = 0;
          int dimregidx = 0;
          for (uint i = 0; i < Dimensions; i++) {
-Line 3812 
 namespace {
+Line 3847 
 namespace {
      int Region::GetDimensionRegionIndexByValue(const uint DimValues[8]) {
          uint8_t bits;
          int veldim = -1;
-         int velbitpos;
+         int velbitpos = 0;
          int bitpos = 0;
          int dimregidx = 0;
          for (uint i = 0; i < Dimensions; i++) {
-Line 4161 
 namespace {
+Line 4196 
 namespace {
              // to handle potential future extensions of the header
              ckScri->SetPos(sizeof(int32_t) + headerSize);
              // read actual script data
-             uint32_t scriptSize = ckScri->GetSize() - ckScri->GetPos();
+             uint32_t scriptSize = uint32_t(ckScri->GetSize() - ckScri->GetPos());
              data.resize(scriptSize);
              for (int i = 0; i < scriptSize; ++i)
                  data[i] = ckScri->ReadUint8();
-Line 4212 
 namespace {
+Line 4247 
 namespace {
          // recalculate CRC32 check sum
          __resetCRC(crc);
          __calculateCRC(&data[0], data.size(), crc);
-         __encodeCRC(crc);
+         __finalizeCRC(crc);
          // make sure chunk exists and has the required size
-         const int chunkSize = 7*sizeof(int32_t) + Name.size() + data.size();
+         const file_offset_t chunkSize = (file_offset_t) 7*sizeof(int32_t) + Name.size() + data.size();
          if (!pChunk) pChunk = pGroup->pList->AddSubChunk(CHUNK_ID_SCRI, chunkSize);
          else pChunk->Resize(chunkSize);
          // fill the chunk data to be written to disk
          uint8_t* pData = (uint8_t*) pChunk->LoadChunkData();
          int pos = 0;
-         store32(&pData[pos], 6*sizeof(int32_t) + Name.size()); // total header size
+         store32(&pData[pos], uint32_t(6*sizeof(int32_t) + Name.size())); // total header size
          pos += sizeof(int32_t);
          store32(&pData[pos], Compression);
          pos += sizeof(int32_t);
-Line 4232 
 namespace {
+Line 4267 
 namespace {
          pos += sizeof(int32_t);
          store32(&pData[pos], crc);
          pos += sizeof(int32_t);
-         store32(&pData[pos], Name.size());
+         store32(&pData[pos], (uint32_t) Name.size());
          pos += sizeof(int32_t);
          for (int i = 0; i < Name.size(); ++i, ++pos)
              pData[pos] = Name[i];
-Line 4409 
 namespace {
+Line 4444 
 namespace {
          EffectSend = 0;
          Attenuation = 0;
          FineTune = 0;
-         PitchbendRange = 0;
+         PitchbendRange = 2;
          PianoReleaseMode = false;
          DimensionKeyRange.low = 0;
          DimensionKeyRange.high = 0;
-Line 4584 
 namespace {
+Line 4619 
 namespace {
             RIFF::List* lst3LS = pCkInstrument->GetSubList(LIST_TYPE_3LS);
             if (!lst3LS) lst3LS = pCkInstrument->AddSubList(LIST_TYPE_3LS);
-            const int slotCount = pScriptRefs->size();
+            const int slotCount = (int) pScriptRefs->size();
             const int headerSize = 3 * sizeof(uint32_t);
             const int slotSize  = 2 * sizeof(uint32_t);
             const int totalChunkSize = headerSize + slotCount * slotSize;
-Line 4620 
 namespace {
+Line 4655 
 namespace {
         if (pScriptRefs && pScriptRefs->size() > 0) {
             RIFF::List* lst3LS = pCkInstrument->GetSubList(LIST_TYPE_3LS);
             RIFF::Chunk* ckSCSL = lst3LS->GetSubChunk(CHUNK_ID_SCSL);
-            const int slotCount = pScriptRefs->size();
+            const int slotCount = (int) pScriptRefs->size();
             const int headerSize = 3 * sizeof(uint32_t);
             ckSCSL->SetPos(headerSize);
             for (int i = 0; i < slotCount; ++i) {
-                uint32_t fileOffset =
+                uint32_t fileOffset = uint32_t(
                      (*pScriptRefs)[i].script->pChunk->GetFilePos() -
                      (*pScriptRefs)[i].script->pChunk->GetPos() -
-                     CHUNK_HEADER_SIZE(ckSCSL->GetFile()->GetFileOffsetSize());
+                     CHUNK_HEADER_SIZE(ckSCSL->GetFile()->GetFileOffsetSize())
+                );
                 ckSCSL->WriteUint32(&fileOffset);
                 // jump over flags entry (containing the bypass flag)
                 ckSCSL->SetPos(sizeof(uint32_t), RIFF::stream_curpos);
-Line 4687 
 namespace {
+Line 4723 
 namespace {
          RIFF::List* rgn = lrgn->AddSubList(LIST_TYPE_RGN);
          Region* pNewRegion = new Region(this, rgn);
          pRegions->push_back(pNewRegion);
-         Regions = pRegions->size();
+         Regions = (uint32_t) pRegions->size();
          // update Region key table for fast lookup
          UpdateRegionKeyTable();
          // done
-Line 4833 
 namespace {
+Line 4869 
 namespace {
                  for (uint s = 0; group->GetScript(s); ++s) {
                      Script* script = group->GetScript(s);
                      if (script->pChunk) {
-                         uint32_t offset = script->pChunk->GetFilePos() -
+                         uint32_t offset = uint32_t(
-                                           script->pChunk->GetPos() -
+                             script->pChunk->GetFilePos() -
-                                           CHUNK_HEADER_SIZE(script->pChunk->GetFile()->GetFileOffsetSize());
+                             script->pChunk->GetPos() -
+                             CHUNK_HEADER_SIZE(script->pChunk->GetFile()->GetFileOffsetSize())
+                         );
                          if (offset == soughtOffset)
                          {
                              _ScriptPooolRef ref;
-Line 4960 
 namespace {
+Line 4998 
 namespace {
       */
      void Instrument::RemoveScript(Script* pScript) {
          LoadScripts();
-         for (int i = pScriptRefs->size() - 1; i >= 0; --i) {
+         for (ssize_t i = pScriptRefs->size() - 1; i >= 0; --i) {
              if ((*pScriptRefs)[i].script == pScript) {
                  pScriptRefs->erase( pScriptRefs->begin() + i );
              }
-Line 4982 
 namespace {
+Line 5020 
 namespace {
       * gigedit.
       */
      uint Instrument::ScriptSlotCount() const {
-         return pScriptRefs ? pScriptRefs->size() : scriptPoolFileOffsets.size();
+         return uint(pScriptRefs ? pScriptRefs->size() : scriptPoolFileOffsets.size());
      }
      /** @brief Whether script execution shall be skipped.
-Line 5406 
 namespace {
+Line 5444 
 namespace {
              }
          }
          String name(pRIFF->GetFileName());
-         int nameLen = name.length();
+         int nameLen = (int) name.length();
          char suffix[6];
          if (nameLen > 4 && name.substr(nameLen - 4) == ".gig") nameLen -= 4;
-Line 5422 
 namespace {
+Line 5460 
 namespace {
                          __notify_progress(pProgress, subprogress);
                          file_offset_t waveFileOffset = wave->GetFilePos();
-                         pSamples->push_back(new Sample(this, wave, waveFileOffset - wvplFileOffset, fileNo));
+                         pSamples->push_back(new Sample(this, wave, waveFileOffset - wvplFileOffset, fileNo, iSampleIndex));
                          iSampleIndex++;
                      }
-Line 5668 
 namespace {
+Line 5706 
 namespace {
          uint32_t one = 1;
          _3crc->WriteUint32(&one); // always 1
          _3crc->WriteUint32(&crc);
-         // reload CRC table to RAM to keep it persistent over several subsequent save operations
-         _3crc->ReleaseChunkData();
-         _3crc->LoadChunkData();
      }
      uint32_t File::GetSampleChecksum(Sample* pSample) {
+         // get the index of the sample
+         int iWaveIndex = GetWaveTableIndexOf(pSample);
+         if (iWaveIndex < 0) throw gig::Exception("Could not retrieve reference crc of sample, could not resolve sample's wave table index");
+         return GetSampleChecksumByIndex(iWaveIndex);
+     }
+     uint32_t File::GetSampleChecksumByIndex(int index) {
+         if (index < 0) throw gig::Exception("Could not retrieve reference crc of sample, invalid wave pool index of sample");
          RIFF::Chunk* _3crc = pRIFF->GetSubChunk(CHUNK_ID_3CRC);
          if (!_3crc) throw gig::Exception("Could not retrieve reference crc of sample, no checksums stored for this file yet");
          uint8_t* pData = (uint8_t*) _3crc->LoadChunkData();
          if (!pData) throw gig::Exception("Could not retrieve reference crc of sample, no checksums stored for this file yet");
-         // get the index of the sample
-         int iWaveIndex = GetWaveTableIndexOf(pSample);
-         if (iWaveIndex < 0) throw gig::Exception("Could not retrieve reference crc of sample, could not resolve sample's wave table index");
          // read the CRC-32 checksum directly from disk
-         size_t pos = iWaveIndex * 8;
+         size_t pos = index * 8;
          if (pos + 8 > _3crc->GetNewSize())
              throw gig::Exception("Could not retrieve reference crc of sample, could not seek to required position in crc chunk");
          uint32_t one = load32(&pData[pos]); // always 1
          if (one != 1)
-             throw gig::Exception("Could not verify sample, because reference checksum table is damaged");
+             throw gig::Exception("Could not retrieve reference crc of sample, because reference checksum table is damaged");
          return load32(&pData[pos+4]);
      }
      int File::GetWaveTableIndexOf(gig::Sample* pSample) {
          if (!pSamples) GetFirstSample(); // make sure sample chunks were scanned
          File::SampleList::iterator iter = pSamples->begin();
-Line 5720 
 namespace {
+Line 5760 
 namespace {
          if (!pSamples) GetFirstSample(); // make sure sample chunks were scanned
          if (_3crc->GetNewSize() != pSamples->size() * 8) return false;
-         const int n = _3crc->GetNewSize() / 8;
+         const file_offset_t n = _3crc->GetNewSize() / 8;
          uint32_t* pData = (uint32_t*) _3crc->LoadChunkData();
          if (!pData) return false;
-         for (int i = 0; i < n; ++i) {
+         for (file_offset_t i = 0; i < n; ++i) {
              uint32_t one = pData[i*2];
              if (one != 1) return false;
          }
-Line 5759 
 namespace {
+Line 5799 
 namespace {
          RIFF::Chunk* _3crc = pRIFF->GetSubChunk(CHUNK_ID_3CRC);
          if (!_3crc) {
              _3crc = pRIFF->AddSubChunk(CHUNK_ID_3CRC, pSamples->size() * 8);
+             // the order of einf and 3crc is not the same in v2 and v3
+             RIFF::Chunk* einf = pRIFF->GetSubChunk(CHUNK_ID_EINF);
+             if (einf && pVersion && pVersion->major == 3) pRIFF->MoveSubChunk(_3crc, einf);
              bRequiresSave = true;
          } else if (_3crc->GetNewSize() != pSamples->size() * 8) {
              _3crc->Resize(pSamples->size() * 8);
-Line 5788 
 namespace {
+Line 5831 
 namespace {
                      gig::Sample* pSample = (gig::Sample*) *iter;
                      int index = GetWaveTableIndexOf(pSample);
                      if (index < 0) throw gig::Exception("Could not rebuild crc table for samples, wave table index of a sample could not be resolved");
-                     uint32_t crc = pSample->CalculateWaveDataChecksum();
+                     pSample->crc  = pSample->CalculateWaveDataChecksum();
-                     SetSampleChecksum(pSample, crc);
+                     SetSampleChecksum(pSample, pSample->crc);
                  }
              }
          }
-Line 6056 
 namespace {
+Line 6099 
 namespace {
              lst3LS = NULL;
          }
-         // if there is a 3CRC chunk, make sure it is loaded into RAM, otherwise
-         // its data might get lost or damaged on file structure changes
-         RIFF::Chunk* _3crc = pRIFF->GetSubChunk(CHUNK_ID_3CRC);
-         if (_3crc) _3crc->LoadChunkData();
          // first update base class's chunks
          DLS::File::UpdateChunks(pProgress);
-Line 6119 
 namespace {
+Line 6157 
 namespace {
          // Note that there are several fields with unknown use. These
          // are set to zero.
-         int sublen = pSamples->size() / 8 + 49;
+         int sublen = int(pSamples->size() / 8 + 49);
          int einfSize = (Instruments + 1) * sublen;
          RIFF::Chunk* einf = pRIFF->GetSubChunk(CHUNK_ID_EINF);
-Line 6192 
 namespace {
+Line 6230 
 namespace {
                  store32(&pData[(instrumentIdx + 1) * sublen + 24], nbloops);
                  // next 8 bytes unknown
                  store32(&pData[(instrumentIdx + 1) * sublen + 36], instrumentIdx);
-                 store32(&pData[(instrumentIdx + 1) * sublen + 40], pSamples->size());
+                 store32(&pData[(instrumentIdx + 1) * sublen + 40], (uint32_t) pSamples->size());
                  // next 4 bytes unknown
                  totnbregions += instrument->Regions;
-Line 6210 
 namespace {
+Line 6248 
 namespace {
              store32(&pData[24], totnbloops);
              // next 8 bytes unknown
              // next 4 bytes unknown, not always 0
-             store32(&pData[40], pSamples->size());
+             store32(&pData[40], (uint32_t) pSamples->size());
              // next 4 bytes unknown
          }
          // update 3crc chunk
          // The 3crc chunk contains CRC-32 checksums for the
-         // samples. The actual checksum values will be filled in
+         // samples. When saving a gig file to disk, we first update the 3CRC
-         // later, by Sample::Write.
+         // chunk here (in RAM) with the old crc values which we read from the
+         // 3CRC chunk when we opened the file (available with gig::Sample::crc
+         // member variable). This step is required, because samples might have
+         // been deleted by the user since the file was opened, which in turn
+         // changes the order of the (i.e. old) checksums within the 3crc chunk.
+         // If a sample was conciously modified by the user (that is if
+         // Sample::Write() was called later on) then Sample::Write() will just
+         // update the respective individual checksum(s) directly on disk and
+         // leaves all other sample checksums untouched.
+         RIFF::Chunk* _3crc = pRIFF->GetSubChunk(CHUNK_ID_3CRC);
          if (_3crc) {
              _3crc->Resize(pSamples->size() * 8);
-         } else if (newFile) {
+         } else /*if (newFile)*/ {
              _3crc = pRIFF->AddSubChunk(CHUNK_ID_3CRC, pSamples->size() * 8);
-             _3crc->LoadChunkData();
              // the order of einf and 3crc is not the same in v2 and v3
              if (einf && pVersion && pVersion->major == 3) pRIFF->MoveSubChunk(_3crc, einf);
          }
+         { // must be performed in RAM here ...
+             uint32_t* pData = (uint32_t*) _3crc->LoadChunkData();
+             if (pData) {
+                 File::SampleList::iterator iter = pSamples->begin();
+                 File::SampleList::iterator end  = pSamples->end();
+                 for (int index = 0; iter != end; ++iter, ++index) {
+                     gig::Sample* pSample = (gig::Sample*) *iter;
+                     pData[index*2]   = 1; // always 1
+                     pData[index*2+1] = pSample->crc;
+                 }
+             }
+         }
      }
      void File::UpdateFileOffsets() {

 Legend:



Removed from v.2985
 


changed lines


 
Added in v.3115
 Legend:



Removed from v.2985
 


changed lines


 
Added in v.3115
-Removed from v.2985
+Added in v.3115

	ViewVC Help
Powered by ViewVC