/[svn]/gigedit/trunk/src/gigedit/mainwindow.cpp

Diff of /gigedit/trunk/src/gigedit/mainwindow.cpp

Parent Directory | Revision Log | View Patch Patch

-revision 3460 by persson,
Sat Feb  2 07:48:50 2019 UTC
+revision 3737 by schoenebeck,
Sat Feb  1 20:39:39 2020 UTC
 Line 1
  /*
-  * Copyright (C) 2006-2019 Andreas Persson
+  * Copyright (C) 2006-2020 Andreas Persson
   *
   * This program is free software; you can redistribute it and/or
   * modify it under the terms of the GNU General Public License as
 Line 21
  #include <cstring>
  #include "compat.h"
- // threads.h must be included first to be able to build with
- // G_DISABLE_DEPRECATED
- #if (GLIBMM_MAJOR_VERSION == 2 && GLIBMM_MINOR_VERSION == 31 && GLIBMM_MICRO_VERSION >= 2) || \
-     (GLIBMM_MAJOR_VERSION == 2 && GLIBMM_MINOR_VERSION > 31) || GLIBMM_MAJOR_VERSION > 2
- #include <glibmm/threads.h>
- #endif
  #include <glibmm/convert.h>
  #include <glibmm/dispatcher.h>
-Line 102 
 MainWindow::MainWindow() :
+Line 96 
 MainWindow::MainWindow() :
      if (!Settings::singleton()->autoRestoreWindowDimension) {
  #if GTKMM_MAJOR_VERSION >= 3
-         set_default_size(895, 600);
+         set_default_size(1010, -1);
  #else
-         set_default_size(800, 600);
+         set_default_size(915, -1);
  #endif
          set_position(Gtk::WIN_POS_CENTER);
      }
-Line 457 
 MainWindow::MainWindow() :
+Line 451 
 MainWindow::MainWindow() :
          m_actionGroup->add_action_bool("Statusbar", sigc::mem_fun(*this, &MainWindow::on_action_view_status_bar), true);
      m_actionToggleRestoreWinDim =
          m_actionGroup->add_action_bool("AutoRestoreWinDim", sigc::mem_fun(*this, &MainWindow::on_auto_restore_win_dim), Settings::singleton()->autoRestoreWindowDimension);
+     m_actionInstrDoubleClickOpensProps =
+         m_actionGroup->add_action_bool(
+             "OpenInstrPropsByDoubleClick",
+             sigc::mem_fun(*this, &MainWindow::on_instr_double_click_opens_props),
+             Settings::singleton()->instrumentDoubleClickOpensProps
+         );
      m_actionToggleShowTooltips = m_actionGroup->add_action_bool(
          "ShowTooltips", sigc::mem_fun(*this, &MainWindow::on_action_show_tooltips),
          Settings::singleton()->showTooltips
 Line 484 
 MainWindow::MainWindow() :
                           *this, &MainWindow::on_auto_restore_win_dim));
      toggle_action =
+         Gtk::ToggleAction::create("OpenInstrPropsByDoubleClick", _("Instrument Properties by Double Click"));
+     toggle_action->set_active(Settings::singleton()->instrumentDoubleClickOpensProps);
+     actionGroup->add(toggle_action,
+                      sigc::mem_fun(
+                          *this, &MainWindow::on_instr_double_click_opens_props));
+     toggle_action =
          Gtk::ToggleAction::create("ShowTooltips", _("Tooltips for Beginners"));
      toggle_action->set_active(Settings::singleton()->showTooltips);
      actionGroup->add(
-Line 515 
 MainWindow::MainWindow() :
+Line 522 
 MainWindow::MainWindow() :
          "DupInstrument", sigc::mem_fun(*this, &MainWindow::on_action_duplicate_instrument)
      );
      m_actionGroup->add_action(
+         "MoveInstrument", sigc::mem_fun(*this, &MainWindow::on_action_move_instr)
+     );
+     m_actionGroup->add_action(
          "CombInstruments", sigc::mem_fun(*this, &MainWindow::on_action_combine_instruments)
      );
      m_actionGroup->add_action(
-Line 536 
 MainWindow::MainWindow() :
+Line 546 
 MainWindow::MainWindow() :
          sigc::mem_fun(*this, &MainWindow::on_action_duplicate_instrument)
      );
      actionGroup->add(
+         Gtk::Action::create("MoveInstrument", _("Move _Instrument To ...")),
+         Gtk::AccelKey(GDK_KEY_i, primaryModifierKey),
+         sigc::mem_fun(*this, &MainWindow::on_action_move_instr)
+     );
+     actionGroup->add(
          Gtk::Action::create("CombInstruments", _("_Combine Instruments ...")),
          Gtk::AccelKey(GDK_KEY_j, primaryModifierKey),
          sigc::mem_fun(*this, &MainWindow::on_action_combine_instruments)
-Line 891 
 MainWindow::MainWindow() :
+Line 906 
 MainWindow::MainWindow() :
          "          <attribute name='label' translatable='yes'>Duplicate Instrument</attribute>"
          "          <attribute name='action'>AppMenu.DupInstrument</attribute>"
          "        </item>"
+         "        <item id='MoveInstrument'>"
+         "          <attribute name='label' translatable='yes'>Move Instrument To ...</attribute>"
+         "          <attribute name='action'>AppMenu.MoveInstrument</attribute>"
+         "        </item>"
          "        <item id='CombInstruments'>"
          "          <attribute name='label' translatable='yes'>Combine Instrument</attribute>"
          "          <attribute name='action'>AppMenu.CombInstruments</attribute>"
-Line 941 
 MainWindow::MainWindow() :
+Line 960 
 MainWindow::MainWindow() :
          "          <attribute name='label' translatable='yes'>Auto restore Window Dimensions</attribute>"
          "          <attribute name='action'>AppMenu.AutoRestoreWinDim</attribute>"
          "        </item>"
+         "        <item id='OpenInstrPropsByDoubleClick'>"
+         "          <attribute name='label' translatable='yes'>Instrument Properties by Double Click</attribute>"
+         "          <attribute name='action'>AppMenu.OpenInstrPropsByDoubleClick</attribute>"
+         "        </item>"
          "      </section>"
          "      <section>"
          "        <item id='RefreshAll'>"
-Line 1016 
 MainWindow::MainWindow() :
+Line 1039 
 MainWindow::MainWindow() :
          "        <attribute name='label' translatable='yes'>Duplicate Instrument</attribute>"
          "        <attribute name='action'>AppMenu.DupInstrument</attribute>"
          "      </item>"
+         "      <item id='MoveInstrument'>"
+         "        <attribute name='label' translatable='yes'>Move Instrument To ...</attribute>"
+         "        <attribute name='action'>AppMenu.MoveInstrument</attribute>"
+         "      </item>"
          "      <item id='CombInstruments'>"
          "        <attribute name='label' translatable='yes'>Combine Instruments</attribute>"
          "        <attribute name='action'>AppMenu.CombInstruments</attribute>"
-Line 1154 
 MainWindow::MainWindow() :
+Line 1181 
 MainWindow::MainWindow() :
          "      <menu action='AssignScripts'/>"
          "      <menuitem action='AddInstrument'/>"
          "      <menuitem action='DupInstrument'/>"
+         "      <menuitem action='MoveInstrument'/>"
          "      <menuitem action='CombInstruments'/>"
          "      <separator/>"
          "      <menuitem action='RemoveInstrument'/>"
-Line 1169 
 MainWindow::MainWindow() :
+Line 1197 
 MainWindow::MainWindow() :
          "      <menuitem action='Statusbar'/>"
          "      <menuitem action='ShowTooltips'/>"
          "      <menuitem action='AutoRestoreWinDim'/>"
+         "      <menuitem action='OpenInstrPropsByDoubleClick'/>"
          "      <separator/>"
          "      <menuitem action='RefreshAll'/>"
          "    </menu>"
-Line 1192 
 MainWindow::MainWindow() :
+Line 1221 
 MainWindow::MainWindow() :
          "    <menuitem action='ScriptSlots'/>"
          "    <menuitem action='AddInstrument'/>"
          "    <menuitem action='DupInstrument'/>"
+         "    <menuitem action='MoveInstrument'/>"
          "    <menuitem action='CombInstruments'/>"
          "    <separator/>"
          "    <menuitem action='RemoveInstrument'/>"
-Line 1292 
 MainWindow::MainWindow() :
+Line 1322 
 MainWindow::MainWindow() :
      }
      {
          Gtk::MenuItem* item = dynamic_cast<Gtk::MenuItem*>(
+             uiManager->get_widget("/MenuBar/MenuView/OpenInstrPropsByDoubleClick"));
+         item->set_tooltip_text(_("If checked, double clicking an instrument opens its properties dialog."));
+     }
+     {
+         Gtk::MenuItem* item = dynamic_cast<Gtk::MenuItem*>(
              uiManager->get_widget("/MenuBar/MenuTools/CombineInstruments"));
          item->set_tooltip_text(_("Create combi sounds out of individual sounds of this .gig file."));
      }
-Line 1490 
 MainWindow::MainWindow() :
+Line 1525 
 MainWindow::MainWindow() :
          sigc::mem_fun(*this, &MainWindow::file_changed));
      instrumentProps.signal_changed().connect(
          sigc::mem_fun(*this, &MainWindow::file_changed));
-     propDialog.signal_changed().connect(
+     sampleProps.signal_changed().connect(
+         sigc::mem_fun(*this, &MainWindow::file_changed));
+     fileProps.signal_changed().connect(
          sigc::mem_fun(*this, &MainWindow::file_changed));
      midiRules.signal_changed().connect(
          sigc::mem_fun(*this, &MainWindow::file_changed));
-Line 1512 
 MainWindow::MainWindow() :
+Line 1549 
 MainWindow::MainWindow() :
          sigc::mem_fun(*this, &MainWindow::select_sample)
      );
+     dimreg_edit.editScriptSlotsButton.signal_clicked().connect(
+         sigc::mem_fun(*this, &MainWindow::show_script_slots)
+     );
+     // simply sending the same signal (pair) to the sampler on 'patch' variable
+     // changes as the already existing signal (pair) when the user edits the
+     // script's source code, because the sampler would reload the source code
+     // and the 'patch' variables from the instrument on this signal anyway
+     dimreg_edit.scriptVars.signal_vars_to_be_changed.connect(
+         [this](gig::Instrument* instr) {
+             for (int i = 0; i < instr->ScriptSlotCount(); ++i) {
+                 gig::Script* script = instr->GetScriptOfSlot(i);
+                 signal_script_to_be_changed.emit(script);
+             }
+         }
+     );
+     dimreg_edit.scriptVars.signal_vars_changed.connect(
+         [this](gig::Instrument* instr) {
+             for (int i = 0; i < instr->ScriptSlotCount(); ++i) {
+                 gig::Script* script = instr->GetScriptOfSlot(i);
+                 signal_script_changed.emit(script);
+             }
+         }
+     );
      m_RegionChooser.signal_instrument_struct_to_be_changed().connect(
          sigc::hide(
              sigc::bind(
                  file_structure_to_be_changed_signal.make_slot(),
+ #if SIGCXX_MAJOR_VERSION > 2 || (SIGCXX_MAJOR_VERSION == 2 && SIGCXX_MINOR_VERSION >= 8)
+                 std::ref(this->file)
+ #else
                  sigc::ref(this->file)
+ #endif
              )
          )
      );
-Line 1524 
 MainWindow::MainWindow() :
+Line 1589 
 MainWindow::MainWindow() :
          sigc::hide(
              sigc::bind(
                  file_structure_changed_signal.make_slot(),
+ #if SIGCXX_MAJOR_VERSION > 2 || (SIGCXX_MAJOR_VERSION == 2 && SIGCXX_MINOR_VERSION >= 8)
+                 std::ref(this->file)
+ #else
                  sigc::ref(this->file)
+ #endif
              )
          )
      );
-Line 1546 
 MainWindow::MainWindow() :
+Line 1615 
 MainWindow::MainWindow() :
          sigc::mem_fun(*this, &MainWindow::update_dimregs));
      m_searchText.signal_changed().connect(
-         sigc::mem_fun(m_refTreeModelFilter.operator->(), &Gtk::TreeModelFilter::refilter)
+         sigc::mem_fun(*m_refTreeModelFilter.operator->(), &Gtk::TreeModelFilter::refilter)
      );
      file = 0;
-Line 1877 
 void MainWindow::on_sel_change()
+Line 1946 
 void MainWindow::on_sel_change()
      updateScriptListOfMenu();
-     m_RegionChooser.set_instrument(get_instrument());
+     gig::Instrument* instr = get_instrument();
+     m_RegionChooser.set_instrument(instr);
+     dimreg_edit.scriptVars.setInstrument(instr, true/*force update*/);
      if (Settings::singleton()->syncSamplerInstrumentSelection) {
          switch_sampler_instrument_signal.emit(get_instrument());
      }
  }
+ LoaderSaverBase::LoaderSaverBase(const Glib::ustring filename, gig::File* gig) :
+     filename(filename), gig(gig),
+ #ifdef GLIB_THREADS
+     thread(0),
+ #endif
+     progress(0.f)
+ {
+ }
  void loader_progress_callback(gig::progress_t* progress)
  {
-     Loader* loader = static_cast<Loader*>(progress->custom);
+     LoaderSaverBase* loader = static_cast<LoaderSaverBase*>(progress->custom);
      loader->progress_callback(progress->factor);
  }
- void Loader::progress_callback(float fraction)
+ void LoaderSaverBase::progress_callback(float fraction)
  {
      {
+ #ifdef GLIB_THREADS
          Glib::Threads::Mutex::Lock lock(progressMutex);
+ #else
+         std::lock_guard<std::mutex> lock(progressMutex);
+ #endif
          progress = fraction;
      }
      progress_dispatcher();
-Line 1903 
 void Loader::progress_callback(float fra
+Line 1989 
 void Loader::progress_callback(float fra
  // make sure stack is 16-byte aligned for SSE instructions
  __attribute__((force_align_arg_pointer))
  #endif
- void Loader::thread_function()
+ void LoaderSaverBase::thread_function()
  {
+ #ifdef GLIB_THREADS
      printf("thread_function self=%p\n",
             static_cast<void*>(Glib::Threads::Thread::self()));
+ #else
+     std::cout << "thread_function self=" << std::this_thread::get_id() << "\n";
+ #endif
      printf("Start %s\n", filename.c_str());
      try {
-         RIFF::File* riff = new RIFF::File(filename);
-         gig = new gig::File(riff);
          gig::progress_t progress;
          progress.callback = loader_progress_callback;
          progress.custom = this;
-         gig->GetInstrument(0, &progress);
+         thread_function_sub(progress);
          printf("End\n");
          finished_dispatcher();
      } catch (RIFF::Exception e) {
-Line 1927 
 void Loader::thread_function()
+Line 2015 
 void Loader::thread_function()
      }
  }
- Loader::Loader(const char* filename)
+ void LoaderSaverBase::launch()
-     : filename(filename), gig(0), thread(0), progress(0.f)
- {
- }
- void Loader::launch()
  {
+ #ifdef GLIB_THREADS
  #ifdef OLD_THREADS
-     thread = Glib::Thread::create(sigc::mem_fun(*this, &Loader::thread_function), true);
+     thread = Glib::Thread::create(sigc::mem_fun(*this, &LoaderSaverBase::thread_function), true);
  #else
-     thread = Glib::Threads::Thread::create(sigc::mem_fun(*this, &Loader::thread_function));
+     thread = Glib::Threads::Thread::create(sigc::mem_fun(*this, &LoaderSaverBase::thread_function));
  #endif
      printf("launch thread=%p\n", static_cast<void*>(thread));
+ #else
+     thread = std::thread([this](){ thread_function(); });
+     std::cout << "launch thread=" << thread.get_id() << "\n";
+ #endif
  }
- float Loader::get_progress()
+ float LoaderSaverBase::get_progress()
  {
-     float res;
+ #ifdef GLIB_THREADS
-     {
+     Glib::Threads::Mutex::Lock lock(progressMutex);
-         Glib::Threads::Mutex::Lock lock(progressMutex);
+ #else
-         res = progress;
+     std::lock_guard<std::mutex> lock(progressMutex);
-     }
+ #endif
-     return res;
+     return progress;
  }
- Glib::Dispatcher& Loader::signal_progress()
+ Glib::Dispatcher& LoaderSaverBase::signal_progress()
  {
      return progress_dispatcher;
  }
- Glib::Dispatcher& Loader::signal_finished()
+ Glib::Dispatcher& LoaderSaverBase::signal_finished()
  {
      return finished_dispatcher;
  }
- Glib::Dispatcher& Loader::signal_error()
+ Glib::Dispatcher& LoaderSaverBase::signal_error()
  {
      return error_dispatcher;
  }
- void saver_progress_callback(gig::progress_t* progress)
+ void LoaderSaverBase::join() {
- {
+ #ifdef GLIB_THREADS
-     Saver* saver = static_cast<Saver*>(progress->custom);
+     thread->join();
-     saver->progress_callback(progress->factor);
+ #else
+     thread.join();
+ #endif
  }
- void Saver::progress_callback(float fraction)
+ Loader::Loader(const char* filename) :
+     LoaderSaverBase(filename, 0)
  {
-     {
-         Glib::Threads::Mutex::Lock lock(progressMutex);
-         progress = fraction;
-     }
-     progress_dispatcher.emit();
  }
- #if defined(WIN32) && (__GNUC__ > 4 || (__GNUC__ == 4 && __GNUC_MINOR__ >= 2))
+ void Loader::thread_function_sub(gig::progress_t& progress)
- // make sure stack is 16-byte aligned for SSE instructions
- __attribute__((force_align_arg_pointer))
- #endif
- void Saver::thread_function()
  {
-     printf("thread_function self=%p\n",
+     RIFF::File* riff = new RIFF::File(filename);
-            static_cast<void*>(Glib::Threads::Thread::self()));
+     gig = new gig::File(riff);
-     printf("Start %s\n", filename.c_str());
-     try {
-         gig::progress_t progress;
-         progress.callback = saver_progress_callback;
-         progress.custom = this;
-         // if no filename was provided, that means "save", if filename was provided means "save as"
-         if (filename.empty()) {
-             if (!Settings::singleton()->saveWithTemporaryFile) {
-                 // save directly over the existing .gig file
-                 // (requires less disk space than solution below
-                 // but may be slower)
-                 gig->Save(&progress);
-             } else {
-                 // save the file as separate temporary file first,
-                 // then move the saved file over the old file
-                 // (may result in performance speedup during save)
-                 gig::String tmpname = filename + ".TMP";
-                 gig->Save(tmpname, &progress);
-                 #if defined(WIN32)
-                 if (!DeleteFile(filename.c_str())) {
-                     throw RIFF::Exception("Could not replace original file with temporary file (unable to remove original file).");
-                 }
-                 #else // POSIX ...
-                 if (unlink(filename.c_str())) {
-                     throw RIFF::Exception("Could not replace original file with temporary file (unable to remove original file): " + gig::String(strerror(errno)));
-                 }
-                 #endif
-                 if (rename(tmpname.c_str(), filename.c_str())) {
-                     #if defined(WIN32)
-                     throw RIFF::Exception("Could not replace original file with temporary file (unable to rename temp file).");
-                     #else
-                     throw RIFF::Exception("Could not replace original file with temporary file (unable to rename temp file): " + gig::String(strerror(errno)));
-                     #endif
-                 }
-             }
-         } else {
-             gig->Save(filename, &progress);
-         }
-         printf("End\n");
+     gig->GetInstrument(0, &progress);
-         finished_dispatcher.emit();
-     } catch (RIFF::Exception e) {
-         error_message = e.Message;
-         error_dispatcher.emit();
-     } catch (...) {
-         error_message = _("Unknown exception occurred");
-         error_dispatcher.emit();
-     }
  }
- Saver::Saver(gig::File* file, Glib::ustring filename)
-     : gig(file), filename(filename), thread(0), progress(0.f)
+ Saver::Saver(gig::File* file, Glib::ustring filename) :
+     LoaderSaverBase(filename, file)
  {
  }
- void Saver::launch()
+ void Saver::thread_function_sub(gig::progress_t& progress)
  {
- #ifdef OLD_THREADS
+     // if no filename was provided, that means "save", if filename was provided means "save as"
-     thread = Glib::Thread::create(sigc::mem_fun(*this, &Saver::thread_function), true);
+     if (filename.empty()) {
+         if (!Settings::singleton()->saveWithTemporaryFile) {
+             // save directly over the existing .gig file
+             // (requires less disk space than solution below
+             // but may be slower)
+             gig->Save(&progress);
+         } else {
+             // save the file as separate temporary file first,
+             // then move the saved file over the old file
+             // (may result in performance speedup during save)
+             gig::String tmpname = filename + ".TMP";
+             gig->Save(tmpname, &progress);
+ #if defined(WIN32)
+             if (!DeleteFile(filename.c_str())) {
+                 throw RIFF::Exception("Could not replace original file with temporary file (unable to remove original file).");
+             }
+ #else // POSIX ...
+             if (unlink(filename.c_str())) {
+                 throw RIFF::Exception("Could not replace original file with temporary file (unable to remove original file): " + gig::String(strerror(errno)));
+             }
+ #endif
+             if (rename(tmpname.c_str(), filename.c_str())) {
+ #if defined(WIN32)
+                 throw RIFF::Exception("Could not replace original file with temporary file (unable to rename temp file).");
  #else
-     thread = Glib::Threads::Thread::create(sigc::mem_fun(*this, &Saver::thread_function));
+                 throw RIFF::Exception("Could not replace original file with temporary file (unable to rename temp file): " + gig::String(strerror(errno)));
  #endif
-     printf("launch thread=%p\n", static_cast<void*>(thread));
+             }
- }
+         }
+     } else {
- float Saver::get_progress()
+         gig->Save(filename, &progress);
- {
-     float res;
-     {
-         Glib::Threads::Mutex::Lock lock(progressMutex);
-         res = progress;
      }
-     return res;
- }
- Glib::Dispatcher& Saver::signal_progress()
- {
-     return progress_dispatcher;
  }
- Glib::Dispatcher& Saver::signal_finished()
- {
-     return finished_dispatcher;
- }
- Glib::Dispatcher& Saver::signal_error()
- {
-     return error_dispatcher;
- }
  ProgressDialog::ProgressDialog(const Glib::ustring& title, Gtk::Window& parent)
      : Gtk::Dialog(title, parent, true)
-Line 2235 
 void MainWindow::on_action_file_open()
+Line 2275 
 void MainWindow::on_action_file_open()
          dialog.set_current_folder(current_gig_dir);
      }
      if (dialog.run() == Gtk::RESPONSE_OK) {
+         dialog.hide();
          std::string filename = dialog.get_filename();
          printf("filename=%s\n", filename.c_str());
+ #ifdef GLIB_THREADS
          printf("on_action_file_open self=%p\n",
                 static_cast<void*>(Glib::Threads::Thread::self()));
+ #else
+         std::cout << "on_action_file_open self=" <<
+             std::this_thread::get_id() << "\n";
+ #endif
          load_file(filename.c_str());
          current_gig_dir = Glib::path_get_dirname(filename);
      }
-Line 2311 
 void MainWindow::on_loader_progress()
+Line 2357 
 void MainWindow::on_loader_progress()
  void MainWindow::on_loader_finished()
  {
+     loader->join();
      printf("Loader finished!\n");
+ #ifdef GLIB_THREADS
      printf("on_loader_finished self=%p\n",
             static_cast<void*>(Glib::Threads::Thread::self()));
+ #else
+     std::cout << "on_loader_finished self=" <<
+         std::this_thread::get_id() << "\n";
+ #endif
      load_gig(loader->gig, loader->filename.c_str());
      progress_dialog->hide();
  }
  void MainWindow::on_loader_error()
  {
+     loader->join();
      Glib::ustring txt = _("Could not load file: ") + loader->error_message;
      Gtk::MessageDialog msg(*this, txt, false, Gtk::MESSAGE_ERROR);
      msg.run();
-Line 2390 
 void MainWindow::on_saver_progress()
+Line 2443 
 void MainWindow::on_saver_progress()
  void MainWindow::on_saver_error()
  {
+     saver->join();
      file_structure_changed_signal.emit(this->file);
      Glib::ustring txt = _("Could not save file: ") + saver->error_message;
      Gtk::MessageDialog msg(*this, txt, false, Gtk::MESSAGE_ERROR);
-Line 2398 
 void MainWindow::on_saver_error()
+Line 2452 
 void MainWindow::on_saver_error()
  void MainWindow::on_saver_finished()
  {
+     saver->join();
      this->file = saver->gig;
      this->filename = saver->filename;
      current_gig_dir = Glib::path_get_dirname(filename);
-Line 2489 
 bool MainWindow::file_save_as()
+Line 2544 
 bool MainWindow::file_save_as()
  #endif
      if (dialog.run() == Gtk::RESPONSE_OK) {
+         dialog.hide();
          std::string filename = dialog.get_filename();
          if (!Glib::str_has_suffix(filename, ".gig")) {
              filename += ".gig";
-Line 2617 
 void MainWindow::__import_queued_samples
+Line 2673 
 void MainWindow::__import_queued_samples
  void MainWindow::on_action_file_properties()
  {
-     propDialog.show();
+     fileProps.show();
-     propDialog.deiconify();
+     fileProps.deiconify();
  }
  void MainWindow::on_action_warn_user_on_extensions() {
-Line 2680 
 void MainWindow::on_action_help_about()
+Line 2736 
 void MainWindow::on_action_help_about()
              "backup your Gigasampler/GigaStudio files before editing them with "
              "this application.\n"
              "\n"
-             "Please report bugs to: http://bugs.linuxsampler.org"
+             "Please report bugs to: https://bugs.linuxsampler.org"
          );
      dialog.set_comments(sComment.c_str());
-     dialog.set_website("http://www.linuxsampler.org");
+     dialog.set_website("https://www.linuxsampler.org");
-     dialog.set_website_label("http://www.linuxsampler.org");
+     dialog.set_website_label("https://www.linuxsampler.org");
      dialog.set_position(Gtk::WIN_POS_CENTER);
      dialog.run();
  }
- PropDialog::PropDialog()
+ FilePropDialog::FilePropDialog()
      : eFileFormat(_("File Format")),
        eName(_("Name")),
        eCreationDate(_("Creation date")),
-Line 2723 
 PropDialog::PropDialog()
+Line 2779 
 PropDialog::PropDialog()
      set_title(_("File Properties"));
      eName.set_width_chars(50);
+     connect(eFileFormat, &FilePropDialog::set_FileFormat);
      connect(eName, &DLS::Info::Name);
      connect(eCreationDate, &DLS::Info::CreationDate);
      connect(eComments, &DLS::Info::Comments);
-Line 2783 
 PropDialog::PropDialog()
+Line 2840 
 PropDialog::PropDialog()
      quitButton.set_can_default();
      quitButton.grab_focus();
      quitButton.signal_clicked().connect(
-         sigc::mem_fun(*this, &PropDialog::hide));
+         sigc::mem_fun(*this, &FilePropDialog::hide));
-     eFileFormat.signal_value_changed().connect(
-         sigc::mem_fun(*this, &PropDialog::onFileFormatChanged));
      quitButton.show();
      vbox.show();
-Line 2794 
 PropDialog::PropDialog()
+Line 2849 
 PropDialog::PropDialog()
  #endif
  }
- void PropDialog::set_file(gig::File* file)
+ void FilePropDialog::set_file(gig::File* file)
  {
      m_file = file;
+     update(file->pInfo);
      // update file format version combo box
      const std::string sGiga = "Gigasampler/GigaStudio v";
-Line 2812 
 void PropDialog::set_file(gig::File* fil
+Line 2868 
 void PropDialog::set_file(gig::File* fil
      std::vector<const char*> texts;
      for (int i = 0; i < txts.size(); ++i) texts.push_back(txts[i].c_str());
      texts.push_back(NULL); values.push_back(0);
+     update_model++;
      eFileFormat.set_choices(&texts[0], &values[0]);
      eFileFormat.set_value(major);
+     update_model--;
  }
- void PropDialog::onFileFormatChanged() {
+ void FilePropDialog::set_FileFormat(int value)
-     const int major = eFileFormat.get_value();
-     if (m_file) m_file->pVersion->major = major;
- }
- void PropDialog::set_info(DLS::Info* info)
  {
-     update(info);
+     m_file->pVersion->major = value;
  }
-Line 2865 
 InstrumentProps::InstrumentProps() :
+Line 2919 
 InstrumentProps::InstrumentProps() :
      eIsDrum(_("Is drum")),
      eMIDIBank(_("MIDI bank"), 0, 16383),
      eMIDIProgram(_("MIDI program")),
-     eAttenuation(_("Attenuation"), 0, 96, 0, 1),
+     eAttenuation(_("Attenuation (dB)"), -96, +96, 0, 1),
-     eGainPlus6(_("Gain +6dB"), eAttenuation, -6),
      eEffectSend(_("Effect send"), 0, 65535),
      eFineTune(_("Fine tune"), -8400, 8400),
-     ePitchbendRange(_("Pitchbend range"), 0, 48),
+     ePitchbendRange(_("Pitchbend range (halftones)"), 0, 48),
      ePianoReleaseMode(_("Piano release mode")),
      eDimensionKeyRangeLow(_("Keyswitching range low")),
-     eDimensionKeyRangeHigh(_("Keyswitching range high"))
+     eDimensionKeyRangeHigh(_("Keyswitching range high")),
+     table2(2,1),
+     eName2(_("Name")),
+     eCreationDate(_("Creation date")),
+     eComments(_("Comments")),
+     eProduct(_("Product")),
+     eCopyright(_("Copyright")),
+     eArtists(_("Artists")),
+     eGenre(_("Genre")),
+     eKeywords(_("Keywords")),
+     eEngineer(_("Engineer")),
+     eTechnician(_("Technician")),
+     eSoftware(_("Software")),
+     eMedium(_("Medium")),
+     eSource(_("Source")),
+     eSourceForm(_("Source form")),
+     eCommissioned(_("Commissioned")),
+     eSubject(_("Subject"))
  {
      if (!Settings::singleton()->autoRestoreWindowDimension) {
          //set_default_size(470, 390);
-Line 2881 
 InstrumentProps::InstrumentProps() :
+Line 2951 
 InstrumentProps::InstrumentProps() :
      set_title(_("Instrument Properties"));
+     tabs.append_page(vbox[1], _("Settings"));
+     tabs.append_page(vbox[2], _("Info"));
      eDimensionKeyRangeLow.set_tip(
          _("start of the keyboard area which should switch the "
            "\"keyswitching\" dimension")
-Line 2895 
 InstrumentProps::InstrumentProps() :
+Line 2968 
 InstrumentProps::InstrumentProps() :
      connect(eMIDIBank, &InstrumentProps::set_MIDIBank);
      connect(eMIDIProgram, &InstrumentProps::set_MIDIProgram);
      connect(eAttenuation, &gig::Instrument::Attenuation);
-     connect(eGainPlus6, &gig::Instrument::Attenuation);
      connect(eEffectSend, &gig::Instrument::EffectSend);
      connect(eFineTune, &gig::Instrument::FineTune);
      connect(ePitchbendRange, &gig::Instrument::PitchbendRange);
-Line 2905 
 InstrumentProps::InstrumentProps() :
+Line 2977 
 InstrumentProps::InstrumentProps() :
      eName.signal_value_changed().connect(sig_name_changed.make_slot());
+     connect(eName2, &InstrumentProps::set_Name);
+     connectLambda(eCreationDate, [this](gig::String s) {
+         m->pInfo->CreationDate = s;
+     });
+     connectLambda(eComments, [this](gig::String s) {
+         m->pInfo->Comments = s;
+     });
+     connectLambda(eProduct, [this](gig::String s) {
+         m->pInfo->Product = s;
+     });
+     connectLambda(eCopyright, [this](gig::String s) {
+         m->pInfo->Copyright = s;
+     });
+     connectLambda(eArtists, [this](gig::String s) {
+         m->pInfo->Artists = s;
+     });
+     connectLambda(eGenre, [this](gig::String s) {
+         m->pInfo->Genre = s;
+     });
+     connectLambda(eKeywords, [this](gig::String s) {
+         m->pInfo->Keywords = s;
+     });
+     connectLambda(eEngineer, [this](gig::String s) {
+         m->pInfo->Engineer = s;
+     });
+     connectLambda(eTechnician, [this](gig::String s) {
+         m->pInfo->Technician = s;
+     });
+     connectLambda(eSoftware, [this](gig::String s) {
+         m->pInfo->Software = s;
+     });
+     connectLambda(eMedium, [this](gig::String s) {
+         m->pInfo->Medium = s;
+     });
+     connectLambda(eSource, [this](gig::String s) {
+         m->pInfo->Source = s;
+     });
+     connectLambda(eSourceForm, [this](gig::String s) {
+         m->pInfo->SourceForm = s;
+     });
+     connectLambda(eCommissioned, [this](gig::String s) {
+         m->pInfo->Commissioned = s;
+     });
+     connectLambda(eSubject, [this](gig::String s) {
+         m->pInfo->Subject = s;
+     });
+     // tab 1
  #if USE_GTKMM_GRID
      table.set_column_spacing(5);
  #else
      table.set_col_spacings(5);
  #endif
      table.add(eName);
      table.add(eIsDrum);
      table.add(eMIDIBank);
      table.add(eMIDIProgram);
      table.add(eAttenuation);
-     table.add(eGainPlus6);
      table.add(eEffectSend);
      table.add(eFineTune);
      table.add(ePitchbendRange);
-Line 2924 
 InstrumentProps::InstrumentProps() :
+Line 3042 
 InstrumentProps::InstrumentProps() :
      table.add(eDimensionKeyRangeLow);
      table.add(eDimensionKeyRangeHigh);
-     add(vbox);
+     // tab 2
+ #if USE_GTKMM_GRID
+     table2.set_column_spacing(5);
+ #else
+     table2.set_col_spacings(5);
+ #endif
+     table2.add(eName2);
+     table2.add(eCreationDate);
+     table2.add(eComments);
+     table2.add(eProduct);
+     table2.add(eCopyright);
+     table2.add(eArtists);
+     table2.add(eGenre);
+     table2.add(eKeywords);
+     table2.add(eEngineer);
+     table2.add(eTechnician);
+     table2.add(eSoftware);
+     table2.add(eMedium);
+     table2.add(eSource);
+     table2.add(eSourceForm);
+     table2.add(eCommissioned);
+     table2.add(eSubject);
+     add(vbox[0]);
  #if GTKMM_MAJOR_VERSION > 3 || (GTKMM_MAJOR_VERSION == 3 && GTKMM_MINOR_VERSION > 24)
      table.set_margin(5);
  #else
      table.set_border_width(5);
  #endif
-     vbox.pack_start(table);
+     vbox[1].pack_start(table);
+     vbox[2].pack_start(table2);
      table.show();
-     vbox.pack_start(buttonBox, Gtk::PACK_SHRINK);
+     table2.show();
+     vbox[0].pack_start(tabs);
+     vbox[0].pack_start(buttonBox, Gtk::PACK_SHRINK);
      buttonBox.set_layout(Gtk::BUTTONBOX_END);
  #if GTKMM_MAJOR_VERSION > 3 || (GTKMM_MAJOR_VERSION == 3 && GTKMM_MINOR_VERSION > 24)
      buttonBox.set_margin(5);
-Line 2948 
 InstrumentProps::InstrumentProps() :
+Line 3092 
 InstrumentProps::InstrumentProps() :
          sigc::mem_fun(*this, &InstrumentProps::hide));
      quitButton.show();
-     vbox.show();
+     vbox[0].show();
  #if HAS_GTKMM_SHOW_ALL_CHILDREN
      show_all_children();
  #endif
-Line 2959 
 void InstrumentProps::set_instrument(gig
+Line 3103 
 void InstrumentProps::set_instrument(gig
      update(instrument);
      update_model++;
+     // tab 1
      eName.set_value(instrument->pInfo->Name);
      eIsDrum.set_value(instrument->IsDrum);
      eMIDIBank.set_value(instrument->MIDIBank);
      eMIDIProgram.set_value(instrument->MIDIProgram);
+     // tab 2
+     eName2.set_value(instrument->pInfo->Name);
+     eCreationDate.set_value(instrument->pInfo->CreationDate);
+     eComments.set_value(instrument->pInfo->Comments);
+     eProduct.set_value(instrument->pInfo->Product);
+     eCopyright.set_value(instrument->pInfo->Copyright);
+     eArtists.set_value(instrument->pInfo->Artists);
+     eGenre.set_value(instrument->pInfo->Genre);
+     eKeywords.set_value(instrument->pInfo->Keywords);
+     eEngineer.set_value(instrument->pInfo->Engineer);
+     eTechnician.set_value(instrument->pInfo->Technician);
+     eSoftware.set_value(instrument->pInfo->Software);
+     eMedium.set_value(instrument->pInfo->Medium);
+     eSource.set_value(instrument->pInfo->Source);
+     eSourceForm.set_value(instrument->pInfo->SourceForm);
+     eCommissioned.set_value(instrument->pInfo->Commissioned);
+     eSubject.set_value(instrument->pInfo->Subject);
+     update_model--;
+ }
+ SampleProps::SampleProps() :
+ #if HAS_GTKMM_STOCK
+     quitButton(Gtk::Stock::CLOSE),
+ #else
+     quitButton(_("_Close")),
+ #endif
+     table(2,1),
+     eName(_("Name")),
+     eUnityNote(_("Unity Note")),
+     eSampleGroup(_("Sample Group")),
+     eSampleFormatInfo(_("Sample Format")),
+     eSampleID("Sample ID"),
+     eChecksum("Wave Data CRC-32"),
+     eLoopsCount(_("Loops"), 0, 1), // we might support more than 1 loop in future
+     eLoopStart(_("Loop start position"), 0, 9999999),
+     eLoopLength(_("Loop size"), 0, 9999999),
+     eLoopType(_("Loop type")),
+     eLoopPlayCount(_("Playback count")),
+     table2(2,1),
+     eName2(_("Name")),
+     eCreationDate(_("Creation date")),
+     eComments(_("Comments")),
+     eProduct(_("Product")),
+     eCopyright(_("Copyright")),
+     eArtists(_("Artists")),
+     eGenre(_("Genre")),
+     eKeywords(_("Keywords")),
+     eEngineer(_("Engineer")),
+     eTechnician(_("Technician")),
+     eSoftware(_("Software")),
+     eMedium(_("Medium")),
+     eSource(_("Source")),
+     eSourceForm(_("Source form")),
+     eCommissioned(_("Commissioned")),
+     eSubject(_("Subject"))
+ {
+     if (!Settings::singleton()->autoRestoreWindowDimension) {
+         //set_default_size(470, 390);
+         set_position(Gtk::WIN_POS_MOUSE);
+     }
+     set_title(_("Sample Properties"));
+     tabs.append_page(vbox[1], _("Settings"));
+     tabs.append_page(vbox[2], _("Info"));
+     connect(eName, &SampleProps::set_Name);
+     connect(eUnityNote, &gig::Sample::MIDIUnityNote);
+     connect(eLoopsCount, &gig::Sample::Loops);
+     connectLambda(eLoopStart, [this](uint32_t start){
+         m->LoopStart = start;
+         m->LoopEnd = start + m->LoopSize;
+     });
+     connectLambda(eLoopLength, [this](uint32_t length){
+         m->LoopSize = length;
+         m->LoopEnd = m->LoopStart + length;
+     });
+     {
+         const char* choices[] = { _("normal"), _("bidirectional"), _("backward"), 0 };
+         static const gig::loop_type_t values[] = {
+             gig::loop_type_normal,
+             gig::loop_type_bidirectional,
+             gig::loop_type_backward
+         };
+         eLoopType.set_choices(choices, values);
+     }
+     connect(eLoopType, &gig::Sample::LoopType);
+     connect(eLoopPlayCount, &gig::Sample::LoopPlayCount);
+     eName.signal_value_changed().connect(sig_name_changed.make_slot());
+     connect(eName2, &SampleProps::set_Name);
+     connectLambda(eCreationDate, [this](gig::String s) {
+         m->pInfo->CreationDate = s;
+     });
+     connectLambda(eComments, [this](gig::String s) {
+         m->pInfo->Comments = s;
+     });
+     connectLambda(eProduct, [this](gig::String s) {
+         m->pInfo->Product = s;
+     });
+     connectLambda(eCopyright, [this](gig::String s) {
+         m->pInfo->Copyright = s;
+     });
+     connectLambda(eArtists, [this](gig::String s) {
+         m->pInfo->Artists = s;
+     });
+     connectLambda(eGenre, [this](gig::String s) {
+         m->pInfo->Genre = s;
+     });
+     connectLambda(eKeywords, [this](gig::String s) {
+         m->pInfo->Keywords = s;
+     });
+     connectLambda(eEngineer, [this](gig::String s) {
+         m->pInfo->Engineer = s;
+     });
+     connectLambda(eTechnician, [this](gig::String s) {
+         m->pInfo->Technician = s;
+     });
+     connectLambda(eSoftware, [this](gig::String s) {
+         m->pInfo->Software = s;
+     });
+     connectLambda(eMedium, [this](gig::String s) {
+         m->pInfo->Medium = s;
+     });
+     connectLambda(eSource, [this](gig::String s) {
+         m->pInfo->Source = s;
+     });
+     connectLambda(eSourceForm, [this](gig::String s) {
+         m->pInfo->SourceForm = s;
+     });
+     connectLambda(eCommissioned, [this](gig::String s) {
+         m->pInfo->Commissioned = s;
+     });
+     connectLambda(eSubject, [this](gig::String s) {
+         m->pInfo->Subject = s;
+     });
+     // tab 1
+ #if USE_GTKMM_GRID
+     table.set_column_spacing(5);
+ #else
+     table.set_col_spacings(5);
+ #endif
+     table.add(eName);
+     table.add(eUnityNote);
+     table.add(eSampleGroup);
+     table.add(eSampleFormatInfo);
+     table.add(eSampleID);
+     table.add(eChecksum);
+     table.add(eLoopsCount);
+     table.add(eLoopStart);
+     table.add(eLoopLength);
+     table.add(eLoopType);
+     table.add(eLoopPlayCount);
+     // tab 2
+ #if USE_GTKMM_GRID
+     table2.set_column_spacing(5);
+ #else
+     table2.set_col_spacings(5);
+ #endif
+     table2.add(eName2);
+     table2.add(eCreationDate);
+     table2.add(eComments);
+     table2.add(eProduct);
+     table2.add(eCopyright);
+     table2.add(eArtists);
+     table2.add(eGenre);
+     table2.add(eKeywords);
+     table2.add(eEngineer);
+     table2.add(eTechnician);
+     table2.add(eSoftware);
+     table2.add(eMedium);
+     table2.add(eSource);
+     table2.add(eSourceForm);
+     table2.add(eCommissioned);
+     table2.add(eSubject);
+     add(vbox[0]);
+ #if GTKMM_MAJOR_VERSION > 3 || (GTKMM_MAJOR_VERSION == 3 && GTKMM_MINOR_VERSION > 24)
+     table.set_margin(5);
+ #else
+     table.set_border_width(5);
+ #endif
+     vbox[1].pack_start(table);
+     vbox[2].pack_start(table2);
+     table.show();
+     table2.show();
+     vbox[0].pack_start(tabs);
+     vbox[0].pack_start(buttonBox, Gtk::PACK_SHRINK);
+     buttonBox.set_layout(Gtk::BUTTONBOX_END);
+ #if GTKMM_MAJOR_VERSION > 3 || (GTKMM_MAJOR_VERSION == 3 && GTKMM_MINOR_VERSION > 24)
+     buttonBox.set_margin(5);
+ #else
+     buttonBox.set_border_width(5);
+ #endif
+     buttonBox.show();
+     buttonBox.pack_start(quitButton);
+     quitButton.set_can_default();
+     quitButton.grab_focus();
+     quitButton.signal_clicked().connect(
+         sigc::mem_fun(*this, &SampleProps::hide));
+     quitButton.show();
+     vbox[0].show();
+ #if HAS_GTKMM_SHOW_ALL_CHILDREN
+     show_all_children();
+ #endif
+ }
+ void SampleProps::set_sample(gig::Sample* sample)
+ {
+     update(sample);
+     update_model++;
+     // tab 1
+     eName.set_value(sample->pInfo->Name);
+     eUnityNote.set_value(sample->MIDIUnityNote);
+     // show sample group name
+     {
+         Glib::ustring s = "---";
+         if (sample && sample->GetGroup())
+             s = sample->GetGroup()->Name;
+         eSampleGroup.text.set_text(s);
+     }
+     // assemble sample format info string
+     {
+         Glib::ustring s;
+         if (sample) {
+             switch (sample->Channels) {
+                 case 1: s = _("Mono"); break;
+                 case 2: s = _("Stereo"); break;
+                 default:
+                     s = ToString(sample->Channels) + _(" audio channels");
+                     break;
+             }
+             s += " " + ToString(sample->BitDepth) + " Bits";
+             s += " " + ToString(sample->SamplesPerSecond/1000) + "."
+                      + ToString((sample->SamplesPerSecond%1000)/100) + " kHz";
+         } else {
+             s = _("No sample assigned to this dimension region.");
+         }
+         eSampleFormatInfo.text.set_text(s);
+     }
+     // generate sample's memory address pointer string
+     {
+         Glib::ustring s;
+         if (sample) {
+             char buf[64] = {};
+             snprintf(buf, sizeof(buf), "%p", sample);
+             s = buf;
+         } else {
+             s = "---";
+         }
+         eSampleID.text.set_text(s);
+     }
+     // generate raw wave form data CRC-32 checksum string
+     {
+         Glib::ustring s = "---";
+         if (sample) {
+             char buf[64] = {};
+             snprintf(buf, sizeof(buf), "%x", sample->GetWaveDataCRC32Checksum());
+             s = buf;
+         }
+         eChecksum.text.set_text(s);
+     }
+     eLoopsCount.set_value(sample->Loops);
+     eLoopStart.set_value(sample->LoopStart);
+     eLoopLength.set_value(sample->LoopSize);
+     eLoopType.set_value(sample->LoopType);
+     eLoopPlayCount.set_value(sample->LoopPlayCount);
+     // tab 2
+     eName2.set_value(sample->pInfo->Name);
+     eCreationDate.set_value(sample->pInfo->CreationDate);
+     eComments.set_value(sample->pInfo->Comments);
+     eProduct.set_value(sample->pInfo->Product);
+     eCopyright.set_value(sample->pInfo->Copyright);
+     eArtists.set_value(sample->pInfo->Artists);
+     eGenre.set_value(sample->pInfo->Genre);
+     eKeywords.set_value(sample->pInfo->Keywords);
+     eEngineer.set_value(sample->pInfo->Engineer);
+     eTechnician.set_value(sample->pInfo->Technician);
+     eSoftware.set_value(sample->pInfo->Software);
+     eMedium.set_value(sample->pInfo->Medium);
+     eSource.set_value(sample->pInfo->Source);
+     eSourceForm.set_value(sample->pInfo->SourceForm);
+     eCommissioned.set_value(sample->pInfo->Commissioned);
+     eSubject.set_value(sample->pInfo->Subject);
+     update_model--;
+ }
+ void SampleProps::set_Name(const gig::String& name)
+ {
+     m->pInfo->Name = name;
+ }
+ void SampleProps::update_name()
+ {
+     update_model++;
+     eName.set_value(m->pInfo->Name);
      update_model--;
  }
-Line 3058 
 void MainWindow::load_gig(gig::File* gig
+Line 3510 
 void MainWindow::load_gig(gig::File* gig
      file_has_name = filename;
      file_is_changed = false;
-     propDialog.set_file(gig);
+     fileProps.set_file(gig);
-     propDialog.set_info(gig->pInfo);
      instrument_name_connection.block();
      int index = 0;
-Line 3199 
 void MainWindow::instr_name_changed_by_i
+Line 3650 
 void MainWindow::instr_name_changed_by_i
      }
  }
+ bool MainWindow::sample_props_set_sample()
+ {
+     sampleProps.signal_name_changed().clear();
+     std::vector<Gtk::TreeModel::Path> rows = m_TreeViewSamples.get_selection()->get_selected_rows();
+     if (rows.empty()) {
+         sampleProps.hide();
+         return false;
+     }
+     //NOTE: was const_iterator before, which did not compile with GTKMM4 development branch, probably going to be fixed before final GTKMM4 release though.
+     Gtk::TreeModel::iterator it = m_refSamplesTreeModel->get_iter(rows[0]);
+     if (it) {
+         Gtk::TreeModel::Row row = *it;
+         gig::Sample* sample = row[m_SamplesModel.m_col_sample];
+         sampleProps.set_sample(sample);
+         // make sure sample tree is updated when user changes the
+         // sample name in sample properties window
+         sampleProps.signal_name_changed().connect(
+             sigc::bind(
+                 sigc::mem_fun(*this,
+                     &MainWindow::sample_name_changed_by_sample_props
+                 ), it
+             )
+         );
+     } else {
+         sampleProps.hide();
+     }
+     //NOTE: explicit boolean cast required for GTKMM4 development branch here
+     return it ? true : false;
+ }
+ void MainWindow::show_sample_props()
+ {
+     if (sample_props_set_sample()) {
+         sampleProps.show();
+         sampleProps.deiconify();
+     }
+ }
+ void MainWindow::sample_name_changed_by_sample_props(Gtk::TreeModel::iterator& it)
+ {
+     Gtk::TreeModel::Row row = *it;
+     Glib::ustring name = row[m_SamplesModel.m_col_name];
+     gig::Sample* sample = row[m_SamplesModel.m_col_sample];
+     Glib::ustring gigname(gig_to_utf8(sample->pInfo->Name));
+     if (gigname != name) {
+         Gtk::TreeModel::Path path(*it);
+         row[m_SamplesModel.m_col_name] = gigname;
+     }
+ }
  void MainWindow::show_midi_rules()
  {
      if (gig::Instrument* instrument = get_instrument())
-Line 3327 
 void MainWindow::on_auto_restore_win_dim
+Line 3832 
 void MainWindow::on_auto_restore_win_dim
  #endif
  }
+ void MainWindow::on_instr_double_click_opens_props() {
+ #if USE_GLIB_ACTION
+     bool active = false;
+     m_actionInstrDoubleClickOpensProps->get_state(active);
+     // for some reason toggle state does not change automatically
+     active = !active;
+     m_actionInstrDoubleClickOpensProps->change_state(active);
+     Settings::singleton()->instrumentDoubleClickOpensProps = active;
+ #else
+     Gtk::CheckMenuItem* item =
+         dynamic_cast<Gtk::CheckMenuItem*>(uiManager->get_widget("/MenuBar/MenuView/OpenInstrPropsByDoubleClick"));
+     if (!item) {
+         std::cerr << "/MenuBar/MenuView/OpenInstrPropsByDoubleClick == NULL\n";
+         return;
+     }
+     Settings::singleton()->instrumentDoubleClickOpensProps = item->get_active();
+ #endif
+ }
  void MainWindow::on_save_with_temporary_file() {
  #if USE_GLIB_ACTION
      bool active = false;
-Line 3401 
 bool MainWindow::on_button_release(Gdk::
+Line 3925 
 bool MainWindow::on_button_release(Gdk::
  void MainWindow::on_button_release(GdkEventButton* button) {
  #endif
      if (button->type == GDK_2BUTTON_PRESS) {
-         show_instr_props();
+         if (Settings::singleton()->instrumentDoubleClickOpensProps)
+             show_instr_props();
      } else if (button->type == GDK_BUTTON_PRESS && button->button == 3) {
          // gig v2 files have no midi rules
          const bool bEnabled = !(file->pVersion && file->pVersion->major == 2);
-Line 3441 
 void MainWindow::on_instrument_selection
+Line 3966 
 void MainWindow::on_instrument_selection
  }
  #endif
+ void MainWindow::on_action_move_instr() {
+     gig::Instrument* instr = get_instrument();
+     if (!instr) return;
+     int currentIndex = getIndexOf(instr);
+     Gtk::Dialog dialog(_("Move Instrument"), true /*modal*/);
+ #if (GTKMM_MAJOR_VERSION == 2 && GTKMM_MINOR_VERSION < 90) || GTKMM_MAJOR_VERSION < 2
+     Gtk::Adjustment adjustment(
+         currentIndex,
+/*min*/, file->CountInstruments() - 1 /*max*/
+     );
+     Gtk::SpinButton spinBox(adjustment);
+ #else
+     Gtk::SpinButton spinBox(
+         Gtk::Adjustment::create(
+             currentIndex,
+/*min*/, file->CountInstruments() - 1 /*max*/
+         )
+     );
+ #endif
+ #if USE_GTKMM_BOX
+     dialog.get_content_area()->pack_start(spinBox);
+ #else
+     dialog.get_vbox()->pack_start(spinBox);
+ #endif
+ #if HAS_GTKMM_STOCK
+     Gtk::Button* okButton = dialog.add_button(Gtk::Stock::OK, 0);
+     dialog.add_button(Gtk::Stock::CANCEL, 1);
+ #else
+     Gtk::Button* okButton = dialog.add_button(_("_OK"), 0);
+     dialog.add_button(_("_Cancel"), 1);
+ #endif
+     okButton->set_sensitive(false);
+     // show the dialog at a reasonable screen position
+     dialog.set_position(Gtk::WIN_POS_MOUSE);
+     // only enable the 'OK' button if entered new index is not instrument's
+     // current index already
+     spinBox.signal_value_changed().connect([&]{
+         okButton->set_sensitive( spinBox.get_value_as_int() != currentIndex );
+     });
+     // usability acceleration: if user hits enter key on the text entry field
+     // then auto trigger the 'OK' button
+     spinBox.signal_activate().connect([&]{
+         if (okButton->get_sensitive())
+             okButton->clicked();
+     });
+ #if HAS_GTKMM_SHOW_ALL_CHILDREN
+     dialog.show_all_children();
+ #endif
+     if (!dialog.run()) { // 'OK' selected ...
+         int newIndex = spinBox.get_value_as_int();
+         printf("MOVE TO %d\n", newIndex);
+         gig::Instrument* dst = file->GetInstrument(newIndex);
+         instr->MoveTo(dst);
+         __refreshEntireGUI();
+         select_instrument(instr);
+     }
+ }
  void MainWindow::select_instrument(gig::Instrument* instrument) {
      if (!instrument) return;
-Line 3905 
 void MainWindow::on_action_remove_instru
+Line 4490 
 void MainWindow::on_action_remove_instru
  }
  void MainWindow::on_action_sample_properties() {
-     //TODO: show a dialog where the selected sample's properties can be edited
+     show_sample_props();
-     Gtk::MessageDialog msg(
-         *this, _("Sorry, yet to be implemented!"), false, Gtk::MESSAGE_INFO
-     );
-     msg.run();
  }
  void MainWindow::on_action_add_script_group() {
-Line 4128 
 void MainWindow::add_or_replace_sample(b
+Line 4709 
 void MainWindow::add_or_replace_sample(b
          dialog.set_current_folder(current_sample_dir);
      }
      if (dialog.run() == Gtk::RESPONSE_OK) {
+         dialog.hide();
          current_sample_dir = dialog.get_current_folder();
          Glib::ustring error_files;
          std::vector<std::string> filenames = dialog.get_filenames();
-Line 4308 
 void MainWindow::on_action_replace_all_s
+Line 4890 
 void MainWindow::on_action_replace_all_s
      }
      if (dialog.run() == Gtk::RESPONSE_OK)
      {
+         dialog.hide();
          current_sample_dir = dialog.get_current_folder();
          Glib::ustring error_files;
          std::string folder = dialog.get_filename();
-Line 4706 
 void MainWindow::sample_name_changed(con
+Line 5289 
 void MainWindow::sample_name_changed(con
              file_changed();
          }
      }
+     // change name in the sample properties window
+     if (sampleProps.get_sample() == sample && sample) {
+         sampleProps.set_sample(sample);
+     }
  }
  void MainWindow::script_name_changed(const Gtk::TreeModel::Path& path,
-Line 5036 
 void MainWindow::on_action_merge_files()
+Line 5623 
 void MainWindow::on_action_merge_files()
  #endif
      if (dialog.run() == Gtk::RESPONSE_OK) {
+         dialog.hide();
+ #ifdef GLIB_THREADS
          printf("on_action_merge_files self=%p\n",
                 static_cast<void*>(Glib::Threads::Thread::self()));
+ #else
+         std::cout << "on_action_merge_files self=" <<
+             std::this_thread::get_id() << "\n";
+ #endif
          std::vector<std::string> filenames = dialog.get_filenames();
          // merge the selected files to the currently open .gig file

 Legend:



Removed from v.3460
 


changed lines


 
Added in v.3737
 Legend:



Removed from v.3460
 


changed lines


 
Added in v.3737
-Removed from v.3460
+Added in v.3737

	ViewVC Help
Powered by ViewVC